Optimize php bin check

netz98 · Sep 25, 2023 · 039dbb3 · 039dbb3
1 parent 7383bba
commit 039dbb3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/tests/bats/functional_core_commands.bats b/tests/bats/functional_core_commands.bats
@@ -5,13 +5,11 @@ setup() {
     load 'test_helper/bats-assert/load'
 
     declare PHP_BIN
-    PHP_BIN=$(which php)
-    if [ $? -ne 0 ]; then
+    if ! PHP_BIN=$(which php); then
       echo "Error: PHP binary not found"
       exit 1
     fi
 
-
     if [ -z "$N98_MAGERUN2_BIN" ]; then
       echo "ENV variable N98_MAGERUN2_BIN is missing"
       exit 1

diff --git a/tests/bats/functional_magerun_commands.bats b/tests/bats/functional_magerun_commands.bats
@@ -5,8 +5,7 @@ setup() {
     load 'test_helper/bats-assert/load'
 
     declare PHP_BIN
-    PHP_BIN=$(which php)
-    if [ $? -ne 0 ]; then
+    if ! PHP_BIN=$(which php); then
       echo "Error: PHP binary not found"
       exit 1
     fi