workflow

netz98 · Dec 14, 2024 · b0d4ddf · b0d4ddf
1 parent 1563f5a
commit b0d4ddf
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 34 deletions.
diff --git a/.github/workflows/rector.yml b/.github/workflows/rector.yml
@@ -1,4 +1,4 @@
-name: PHP-CS-Fixer
+name: Rector
 
 on:
   push:
@@ -9,7 +9,7 @@ on:
 
 jobs:
   php-cs-fixer:
-    name: Validation
+    name: Rector
     runs-on: [ubuntu-latest]
 
     steps:

diff --git a/.github/workflows/test-magento-open-source.yml b/.github/workflows/test-magento-open-source.yml
@@ -68,7 +68,7 @@ jobs:
         run: echo "N98_MAGERUN_TEST_MAGENTO_ROOT=${{ github.workspace }}/magento" >> $GITHUB_ENV
 
       - name: Run tests
-        run: php -f vendor/bin/phpunit
+        run: php vendor/bin/phpunit --configuration .phpunit.dist.xml
         env:
           COMPOSER_VENDOR_PATH : "${{ github.workspace }}/magento/vendor"
 

diff --git a/.github/workflows/test-openmage-20.0.yml b/.github/workflows/test-openmage-20.0.yml
@@ -75,7 +75,7 @@ jobs:
         run: echo "N98_MAGERUN_TEST_MAGENTO_ROOT=${{ github.workspace }}/magento" >> $GITHUB_ENV
 
       - name: Run tests
-        run: php -f vendor/bin/phpunit
+        run: php vendor/bin/phpunit --configuration .phpunit.dist.xml
         env:
           COMPOSER_VENDOR_PATH : "${{ github.workspace }}/magento/vendor"
 

diff --git a/.github/workflows/test-openmage-20.1.yml b/.github/workflows/test-openmage-20.1.yml
@@ -76,7 +76,7 @@ jobs:
         run: echo "N98_MAGERUN_TEST_MAGENTO_ROOT=${{ github.workspace }}/magento" >> $GITHUB_ENV
 
       - name: Run tests
-        run: php -f vendor/bin/phpunit
+        run: php vendor/bin/phpunit --configuration .phpunit.dist.xml
         env:
           COMPOSER_VENDOR_PATH : "${{ github.workspace }}/magento/vendor"
 

diff --git a/.github/workflows/test-openmage-20.10.yml b/.github/workflows/test-openmage-20.10.yml
@@ -76,7 +76,7 @@ jobs:
         run: echo "N98_MAGERUN_TEST_MAGENTO_ROOT=${{ github.workspace }}/magento" >> $GITHUB_ENV
 
       - name: Run tests
-        run: php -f vendor/bin/phpunit
+        run: php vendor/bin/phpunit --configuration .phpunit.dist.xml
         env:
           COMPOSER_VENDOR_PATH : "${{ github.workspace }}/magento/vendor"
 

diff --git a/.php_cs b/.php_cs
diff --git a/src/N98/Magento/Command/System/Setup/RemoveCommand.php b/src/N98/Magento/Command/System/Setup/RemoveCommand.php
@@ -62,13 +62,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
     public function removeSetupResource(string $moduleName, string $setupResource, OutputInterface $output): void
     {
-        $mageCoreModelAbstract = $this->getMageCoreResource();
-        $writeAdapter = $mageCoreModelAbstract->getConnection('core_write');
+        $mageCoreModelResource = $this->getMageCoreResource();
+        $writeAdapter = $mageCoreModelResource->getConnection('core_write');
         if (!$writeAdapter) {
             throw new RuntimeException('Database not configured');
         }
 
-        $table = $mageCoreModelAbstract->getTableName('core_resource');
+        $table = $mageCoreModelResource->getTableName('core_resource');
 
         if ($writeAdapter->delete($table, ['code = ?' => $setupResource]) > 0) {
             $output->writeln(

diff --git a/tests/N98/Util/AutoloadHandlerTest.php b/tests/N98/Util/AutoloadHandlerTest.php
@@ -11,7 +11,7 @@
 /**
  * Class AutoloadHandlerTest
  *
- * @covers \N98\Util\AutoloadHandler
+ * @covers AutoloadHandler
  * @package N98\Util
  *
  * @author Tom Klingenberg <https://github.com/ktomk>
@@ -40,7 +40,7 @@ public function testCreation()
     public function testNoRegistrationOnCreation()
     {
         $this->expectException(Error::class);
-        $this->expectExceptionMessage('Typed property N98\Util\AutoloadHandler::$splRegistered must not be accessed before initialization');
+        $this->expectExceptionMessage('Typed property ' . AutoloadHandler::class . '::$splRegistered must not be accessed before initialization');
 
         $handler = $this->create(null, AutoloadHandler::NO_AUTO_REGISTER);
         $handler->disable(); // assertions require a disabled handler b/c of exceptions