Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
sreichel committed Dec 16, 2024
1 parent f91279b commit 26d8d8c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/N98/Magento/Command/Config/DeleteCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ protected function _deletePath(InputInterface $input, string $path, int $scopeId

// Delete stores
foreach (Mage::app()->getStores($force) as $store) {
$deleted[] = $this->deleteConfigEntry($path, 'stores', $store->getId());
$deleted[] = $this->deleteConfigEntry($path, 'stores', (int) $store->getId());
}
} else {
$deleted[] = $this->deleteConfigEntry($path, $input->getOption('scope'), $scopeId);
Expand Down
2 changes: 1 addition & 1 deletion tests/N98/Magento/Command/Database/DumpCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
use Symfony\Component\Console\Tester\CommandTester;

/**
* @see \N98\Magento\Command\Database\DumpCommand
* @see DumpCommand
*/
final class DumpCommandTest extends TestCase
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ final class ClassExistsCheckerTest extends TestCase
/**
* @var array
*/
private $cleanup = [];
private array $cleanup = [];

protected function tearDown(): void
{
Expand Down Expand Up @@ -190,10 +190,10 @@ private function getAutoloader()
private function noErrorExceptions($includeIni = true)
{
$displayErrorsOrig = ini_get('display_errors');
$includeIni && ini_set('display_errors', false);
$includeIni && ini_set('display_errors', '0');

$logErrorsOrig = ini_get('log_errors');
$includeIni && ini_set('log_errors', false);
$includeIni && ini_set('log_errors', '0');

$restore = function () use ($displayErrorsOrig, $logErrorsOrig): void {
ini_set('display_errors', $displayErrorsOrig);
Expand Down
2 changes: 1 addition & 1 deletion tests/N98/Util/Console/Helper/DatabaseHelperTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public function testGetMysqlVariable()
// behavior with existent session variable (INTEGER)
$databaseHelper->getConnection()->query('SET @existent = 14;');
$actual = $databaseHelper->getMysqlVariable('existent', '@');
$this->assertSame(14, $actual);
$this->assertSame('14', $actual);

// behavior with non-existent session variable
$actual = $databaseHelper->getMysqlVariable('nonexistent', '@');
Expand Down

0 comments on commit 26d8d8c

Please sign in to comment.