Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience methods to close SimplePool connections #2258

Merged
merged 39 commits into from
Jun 13, 2024

Commits on May 31, 2024

  1. new methods to allow closing connection pool connections either immed…

    …iately, or as soon as the connection is no longer borrowed
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    afec21d View commit details
    Browse the repository at this point in the history
  2. added documentation to make clear that a connection can no longer be …

    …borrowed after a call to restoreAndScheduleClose
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    18961c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85f4de7 View commit details
    Browse the repository at this point in the history
  4. tuning test probabilities

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ce99bb9 View commit details
    Browse the repository at this point in the history
  5. simplify parameter passing to test-caller threads in TestRunner

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0204d83 View commit details
    Browse the repository at this point in the history
  6. fix the test class used in new tests

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    182f609 View commit details
    Browse the repository at this point in the history
  7. there is no need for a special mock connection class for these tests.…

    … The generic MockKeepAliveConnection class is adequate for this test
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    190d3c0 View commit details
    Browse the repository at this point in the history
  8. additional reduction of parameter passing in TestRunner

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9971964 View commit details
    Browse the repository at this point in the history
  9. simplifying testrunner for new tests

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    742d18d View commit details
    Browse the repository at this point in the history
  10. changed new methods to NO LONGER restore a connection when safeClosin…

    …g or scheduling a safeClose
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    55ee472 View commit details
    Browse the repository at this point in the history
  11. updated test classes to work with new safeClose and schedule-safeClos…

    …e methods
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    073b6a6 View commit details
    Browse the repository at this point in the history
  12. add warning that safeClosed or scheduled-safeClosed connectionTokens …

    …must still be restored to the ppol
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2cc9bdf View commit details
    Browse the repository at this point in the history
  13. sheduleSafeClose -> scheduledSafeClose

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    27ed9c1 View commit details
    Browse the repository at this point in the history
  14. standardize on 8 threads for all mock tests

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f9bf849 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    775609c View commit details
    Browse the repository at this point in the history
  16. fixed logging bug where class connection class was logged rather than…

    … connection source-port
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b5d9af2 View commit details
    Browse the repository at this point in the history
  17. fixed order of logs - said connection closure was about to happen AFT…

    …ER it had already happened
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6566410 View commit details
    Browse the repository at this point in the history
  18. add log for case when thread requests to remove connection-tracking f…

    …or a connection that was already-removed by another thread
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    17d93a9 View commit details
    Browse the repository at this point in the history
  19. fixed small typo in docs

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    c33544d View commit details
    Browse the repository at this point in the history
  20. fixed order of log message indicating that a connection was scheduled…

    … for closure
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ad71483 View commit details
    Browse the repository at this point in the history
  21. changed spacing in source code

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    677c2b5 View commit details
    Browse the repository at this point in the history
  22. added docs explaining that its NOT required to close connections from…

    … the connection token: 'It is NOT necessary to use this method to close connections. SimpleConnectionPool and
    
         * SimpleURIConnectionPool are specifically designed to handle unexpected connections closures'
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8eb8a71 View commit details
    Browse the repository at this point in the history
  23. clean up docs a bit

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5efcee2 View commit details
    Browse the repository at this point in the history
  24. emphasis that users should not use this method unless needed

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    bfd881c View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    c51f0ef View commit details
    Browse the repository at this point in the history
  26. source code cleanup

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f953613 View commit details
    Browse the repository at this point in the history
  27. added some clarity in docs

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fb263d4 View commit details
    Browse the repository at this point in the history
  28. made order where call to get 'now' time is made more consistent

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9b0a3f7 View commit details
    Browse the repository at this point in the history
  29. update docs to be clearer on appropriate use of safeClose() and sched…

    …uleSafeClose()
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6a6c3f9 View commit details
    Browse the repository at this point in the history
  30. update docs for safeClose: SimpleUndertowConnectionMaker.instance(), …

    …not SimpleUndertowConnectionMaker.getInstance()
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    be38df9 View commit details
    Browse the repository at this point in the history
  31. update docs for safeClose: fix code example

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    1ab9a15 View commit details
    Browse the repository at this point in the history
  32. additional tweak / simplication of docs for safeClose() and scheduled…

    …SafeClose()
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6087d57 View commit details
    Browse the repository at this point in the history
  33. additional tweak / simplication of docs for safeClose() and scheduled…

    …SafeClose()
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    67c6665 View commit details
    Browse the repository at this point in the history
  34. correction in scheduleSafeClose() docs

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b259edd View commit details
    Browse the repository at this point in the history
  35. small formatting update to the docs for safeClose() and scheduleSafeC…

    …lose()
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    24ed8f5 View commit details
    Browse the repository at this point in the history
  36. changed formatting of docs for safeClose() and scheduleSafeClose(). A…

    …lso, clarified / cleaned code for safeClose()
    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d187a7f View commit details
    Browse the repository at this point in the history
  37. capitalized some log messages for consistency

    Michael Christoff committed May 31, 2024
    Configuration menu
    Copy the full SHA
    235574a View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. made order where call to get 'now' time is made more consistent in sc…

    …heduleSafeClose()
    Michael Christoff committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    30ff58d View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. (1) skip safeClose() and scheduleSafeClose() tests if connectionToken…

    … is null, and (2) rename randomReconnectJitterMs -> randomWaitTimeJitterMs for consistency in the wait() method
    Michael Christoff committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7da1745 View commit details
    Browse the repository at this point in the history