v.external.out: Check for valid array before passing it to qsort (OSG…

…eo#4251) Currently, if 'HAVE_OGR' macro is defined, as part of execution, we sort all formats by name using qsort. But, array containing all formats is assigned based on a conditional and if the conditional fails, it can be NULL. Behavior of qsort when a NULL array is provided is undefined. To avoid getting into that situation, check if the array is NULL before performing qsort on it. Signed-off-by: Mohan Yelugoti <[email protected]>
neteler · Aug 30, 2024 · cdb6282 · cdb6282
1 parent 7df0e7f
commit cdb6282
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/vector/v.external.out/list.c b/vector/v.external.out/list.c
@@ -53,7 +53,8 @@ char **format_list(int *count, size_t *len)
     }
 
     /* order formats by name */
-    qsort(list, *count, sizeof(char *), cmp);
+    if (list)
+        qsort(list, *count, sizeof(char *), cmp);
 #endif
 #if defined HAVE_POSTGRES && !defined HAVE_OGR
     list = G_realloc(list, ((*count) + 1) * sizeof(char *));