Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for schema URL #1

Closed
wants to merge 0 commits into from
Closed

Conversation

josephnoir
Copy link
Contributor

All entries were removed from our RFC bib file. It turns out that the schema url changed from http to https and as a result lxml didn't return the entries anymore. Updating the URL to https seems to fix it.

@josephnoir josephnoir requested a review from miri64 September 2, 2024 13:52
@josephnoir
Copy link
Contributor Author

Seems the tests still fail though ...

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

The test is providing its own fake XML. I think you need to change the URLs to https there as well.

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

That is here:

<rfc-index xmlns="http://www.rfc-editor.org/rfc-index"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.rfc-editor.org/rfc-index
http://www.rfc-editor.org/rfc-index.xsd">

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

(the XSI XMLNS is also available under with HTTPS now.

@miri64 miri64 changed the title Use https Use https for schema URL Sep 2, 2024
@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

It turns out that the schema url changed from http to https and as a result lxml didn't return the entries anymore.

Mhh https://www.rfc-editor.org/rfc-index yields a 404. Are you sure this is the right URL?

@josephnoir
Copy link
Contributor Author

Since I applied the diff from my changes on the server I'm somewhat confident. You are correct though. It is also the string that appears in the XML here: https://www.rfc-editor.org/rfc-index.xml

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

I am debugging it, seems like the mock is wrong as well.

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

Ah, be67807 broke the tests already.

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

So completely unrelated. Since the mock is for urllib.requests.urlopen, requests.get actually returns the content https://example.org.

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

Will fix separately.

@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

Oops, sorry 😅 Pushed wrongly...

@miri64 miri64 mentioned this pull request Sep 2, 2024
@miri64
Copy link
Collaborator

miri64 commented Sep 2, 2024

See #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants