-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https for schema URL #1
Conversation
Seems the tests still fail though ... |
The test is providing its own fake XML. I think you need to change the URLs to |
That is here: ietfbib2bibtex/tests/test_sources.py Lines 72 to 75 in 098833c
|
(the XSI XMLNS is also available under with HTTPS now. |
Mhh https://www.rfc-editor.org/rfc-index yields a 404. Are you sure this is the right URL? |
Since I applied the diff from my changes on the server I'm somewhat confident. You are correct though. It is also the string that appears in the XML here: https://www.rfc-editor.org/rfc-index.xml |
I am debugging it, seems like the mock is wrong as well. |
Ah, be67807 broke the tests already. |
So completely unrelated. Since the mock is for |
Will fix separately. |
Oops, sorry 😅 Pushed wrongly... |
See #3 |
All entries were removed from our RFC bib file. It turns out that the schema url changed from
http
tohttps
and as a result lxml didn't return the entries anymore. Updating the URL tohttps
seems to fix it.