Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor reconciler svc #192

Merged
merged 8 commits into from
Nov 20, 2024
Merged

feat: refactor reconciler svc #192

merged 8 commits into from
Nov 20, 2024

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Nov 19, 2024 •
edited
Loading

  • extract methods for generating and applying change sets into dedicated packages (differ, applier)
  • generate and apply change sets concurrently, including configurable rate limiter to control pressure on NetBox (as it's capabilities depends on available resource limits (CPU, memory, postgres, etc.)

Integration tests:
Screenshot 2024-11-20 at 11 26 12

@mfiedorowicz
fix integration tests config
4af54c2 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
feat: refactor ingestion processor by splitting changeset generation …
6208777 
…and applying into separate packages

Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
feat: refactor ingestion processor - generate and apply changeset con…
9b692cb 
…currently using pipeline strategy

Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz self-assigned this Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.25s github.com/netboxlabs/diode/diode-server/ingester 4.3% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.56s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 3.2% 40 0 0
🟢 PASS 1.49s github.com/netboxlabs/diode/diode-server/reconciler 13.0% 64 0 0
🟢 PASS 1.11s github.com/netboxlabs/diode/diode-server/reconciler/applier 1.0% 1 0 0
🟢 PASS 1.41s github.com/netboxlabs/diode/diode-server/reconciler/differ 34.2% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.0%

mfiedorowicz and others added 2 commits November 19, 2024 22:54
leoparente
leoparente approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@mfiedorowicz mfiedorowicz merged commit 8293c3e into develop Nov 20, 2024
9 checks passed
@mfiedorowicz mfiedorowicz deleted the refactor-reconciler branch November 20, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

Assignees

@mfiedorowicz mfiedorowicz

Labels
dependencies diode-reconciler diode-server go markdown python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfiedorowicz @leoparente