Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Add stateful userspace firewall and remove egress filters #3093

Merged
merged 30 commits into from
Dec 23, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Dec 20, 2024

Describe your changes

  • Add stateful firewall functionality for UDP/TCP/ICMP in userspace firewalll
  • Removes all egress drop rules/filters, still needs refactoring so we don't add output rules to any chains/filters.
  • on Linux, if the OUTPUT policy is DROP then we don't do anything about it (no extra allow rules). This is up to the user, if they don't want anything leaving their machine they'll have to manage these rules explicitly.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal lixmal force-pushed the remove-egress-filters branch from 809d63f to 8216ab6 Compare December 20, 2024 16:53
@lixmal lixmal changed the title [client] Remove egress filters [client] Add stateful userspace firewall and remove egress filters Dec 21, 2024
@lixmal lixmal force-pushed the remove-egress-filters branch from bbd66e1 to 1306da2 Compare December 21, 2024 22:39
@lixmal lixmal force-pushed the remove-egress-filters branch from 2c6e780 to 07019d2 Compare December 22, 2024 13:30
@mlsmaycon mlsmaycon requested a review from Copilot December 23, 2024 16:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

@mlsmaycon mlsmaycon merged commit ad9f044 into main Dec 23, 2024
29 checks passed
@mlsmaycon mlsmaycon deleted the remove-egress-filters branch December 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants