Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Feature - Migration to Zitadel v2 API #2994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

remipcomaite
Copy link

@remipcomaite remipcomaite commented Dec 6, 2024

Describe your changes

Hello,

I propose a PR to migrate to Zitadel API v2.

This allows to authenticate users from different organizations.

The endpoint for the management API changes from "/management/v1" to "/v2".

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2024

CLA assistant check
All committers have signed the CLA.

@remipcomaite remipcomaite changed the title Feature - Migration to Zitadel v2 API [management] Feature - Migration to Zitadel v2 API Dec 6, 2024
@braginini
Copy link
Contributor

Thank you for the contribution @remipcomaite
Is this backwards compatible with the previous version?

@remipcomaite
Copy link
Author

Hello @braginini ,

The code is not backwards compatible because V1 of the API will be deprecated in the long term.
I changed the endpoints and some properties to match the API calls with V2.

@mlsmaycon mlsmaycon requested a review from Copilot December 24, 2024 11:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

management/server/idp/zitadel.go:73

  • The variable name 'ID' has been changed to 'userId'. Ensure that this renaming is consistently applied throughout the codebase to avoid confusion.
ID: string `json:"userId"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants