-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client] Add QUIC support #2962
Open
pappz
wants to merge
24
commits into
main
Choose a base branch
from
relay/quic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Viktor Liu <[email protected]>
- handle the same AlPN list - use dev build tag for debugging purposes
Reduce cognitive complexity
Reduce code of complexity
- remove unused variable - rename Struct
First close the connection with the peers and after close the listeners
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add QUIC protocol support for Relay client and server
The Relay client tries to connect with WS and QUIC to Relay in parallel. After the successful connection is maintained, only one of them and the other will be aborted. The system architecture expects all Relay server instances to accept all protocols. The QUIC will listen on the same port number as the WS, just on UDP.
For the test and dev environment, the code generates a fake certificate for the QUIC server and it will automatically be accepted by the Relay client. It is configurable in build time with the
-tags=devcert
parameter. Keep in mind never to use binary that has been built with these flags in a production system.Issue ticket number and link
Checklist