Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jumpcloud IdP #1124

Merged
merged 36 commits into from
Oct 3, 2023
Merged

Add jumpcloud IdP #1124

merged 36 commits into from
Oct 3, 2023

Conversation

bcmmbaga
Copy link
Contributor

@bcmmbaga bcmmbaga commented Sep 4, 2023

Describe your changes

Added intergration with JumpCloud User API. Use the steps in setup.md for configuration.

Additional changes:

  • Enhance compatibility for providers that lack audience support in the Authorization Code Flow and the Authorization Code Flow with Proof Key for Code Exchange (PKCE) using NETBIRD_DASH_AUTH_USE_AUDIENCE=falseenv
  • Verify tokens by utilizing the client ID when audience support is absent in providers

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@bcmmbaga bcmmbaga marked this pull request as ready for review September 5, 2023 09:22
@mlsmaycon mlsmaycon changed the base branch from main to idp-user-cache October 3, 2023 14:32
@mlsmaycon mlsmaycon changed the base branch from idp-user-cache to main October 3, 2023 14:36
bcmmbaga and others added 3 commits October 3, 2023 18:24
# Conflicts:
#	management/server/account.go
#	management/server/idp/authentik.go
#	management/server/idp/azure.go
#	management/server/idp/google_workspace.go
#	management/server/idp/idp.go
#	management/server/idp/keycloak.go
#	management/server/idp/okta.go
#	management/server/idp/zitadel.go
@mlsmaycon mlsmaycon merged commit 26bbc33 into main Oct 3, 2023
15 checks passed
@mlsmaycon mlsmaycon deleted the jumpcloud-idp branch October 3, 2023 17:33
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
added intergration with JumpCloud User API. Use the steps in setup.md for configuration.

Additional changes:

- Enhance compatibility for providers that lack audience support in the Authorization Code Flow and the Authorization - - Code Flow with Proof Key for Code Exchange (PKCE) using NETBIRD_DASH_AUTH_USE_AUDIENCE=falseenv
- Verify tokens by utilizing the client ID when audience support is absent in providers
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
added intergration with JumpCloud User API. Use the steps in setup.md for configuration.

Additional changes:

- Enhance compatibility for providers that lack audience support in the Authorization Code Flow and the Authorization - - Code Flow with Proof Key for Code Exchange (PKCE) using NETBIRD_DASH_AUTH_USE_AUDIENCE=falseenv
- Verify tokens by utilizing the client ID when audience support is absent in providers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants