[client] Add experimental support for userspace routing #7705
Triggered via pull request
December 31, 2024 12:36
lixmal
Status
Failure
Total duration
12m 21s
Artifacts
–
golangci-lint.yml
on: pull_request
codespell
10s
Matrix: lint
Annotations
31 errors and 2 warnings
|
codespell:
client/firewall/uspfilter/uspfilter.go#L111
chaning ==> chaining, changing
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L156
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L201
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L249
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L448
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L575
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L666
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L785
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L873
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_test.go#L44
cannot use ifaceMock (variable of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (macos-latest):
client/firewall/uspfilter/uspfilter_test.go#L64
cannot use ifaceMock (variable of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L156
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L201
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L249
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L448
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L575
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L666
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L785
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_bench_test.go#L873
cannot use &IFaceMock{…} (value of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_test.go#L44
cannot use ifaceMock (variable of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (ubuntu-latest):
client/firewall/uspfilter/uspfilter_test.go#L64
cannot use ifaceMock (variable of type *IFaceMock) as common.IFaceMapper value in argument to Create: *IFaceMock does not implement common.IFaceMapper (missing method GetDevice)
|
|
lint (windows-latest):
client/firewall/uspfilter/log/log.go#L131
Error return value of `l.buffer.Write` is not checked (errcheck)
|
|
lint (windows-latest):
client/firewall/uspfilter/log/log.go#L187
Error return value of `l.output.Write` is not checked (errcheck)
|
|
lint (windows-latest):
client/firewall/uspfilter/forwarder/forwarder.go#L82
nilness: impossible condition: nil != nil (govet)
|
|
lint (windows-latest):
client/firewall/uspfilter/forwarder/forwarder.go#L85
nilness: impossible condition: nil != nil (govet)
|
|
lint (windows-latest):
client/firewall/uspfilter/forwarder/forwarder.go#L58
printf: fmt.Errorf format %w has arg err of wrong type gvisor.dev/gvisor/pkg/tcpip.Error (govet)
|
|
lint (windows-latest):
client/firewall/uspfilter/forwarder/forwarder.go#L71
printf: fmt.Errorf format %w has arg err of wrong type gvisor.dev/gvisor/pkg/tcpip.Error (govet)
|
|
lint (windows-latest):
client/firewall/uspfilter/conntrack/udp.go#L78
printf: (*github.com/netbirdio/netbird/client/firewall/uspfilter/log.Logger).Trace format %s has arg conn of wrong type *github.com/netbirdio/netbird/client/firewall/uspfilter/conntrack.UDPConnTrack (govet)
|
|
lint (windows-latest):
client/firewall/uspfilter/conntrack/udp.go#L130
printf: (*github.com/netbirdio/netbird/client/firewall/uspfilter/log.Logger).Trace format %s has arg conn of wrong type *github.com/netbirdio/netbird/client/firewall/uspfilter/conntrack.UDPConnTrack (govet)
|
|
lint (windows-latest):
client/firewall/uspfilter/log/ringbuffer.go#L88
function min has same name as predeclared identifier (predeclared)
|
|
lint (windows-latest):
client/firewall/uspfilter/forwarder/udp.go#L134
SA4006: this value of `pConn` is never used (staticcheck)
|
|
codespell
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|