Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): added dropdown for nestjs versions #1638

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Jan 6, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Docs
[x] Other... Please describe:

What is the current behavior?

Issue Number: "takes its cue from this problem" #64

What is the new behavior?

N/A

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR, added to the dropdown for nestjs versions, could be a useful addition to the documentation, to navigate between the old and new versions of NestJS, I am attaching here two screenshots both when the menu is open and when it is closed.

Also in the future as there are more versions of NestJS it could be useful.

dropdown open:
draft-version-nest-menu-open

dropdown close:
draft-version-nest-menu-close

a small clip:

draft-version-nest-menu.mov

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit, this looks pretty cool. I personally like that it opens a new tab for the version as the version is just a snapshot of the last push for that version.

Definitely a blast from the past to see v4 and v5.

@kkoomen
Copy link

kkoomen commented Jan 8, 2021

Good addition. I think we should make the label include the version or do something equivalent like laravel: https://laravel.com/docs/8.x

We can do : Version: ${version} so that a user always can quickly confirm the current documentation version he/she is looking at.

@Tony133
Copy link
Contributor Author

Tony133 commented Mar 25, 2022

Hi all, I have updated the dropdown version by adding the latest version now it is dynamic based on the npm publication (see screenshot), let me know what you think.

screen

@Tony133 Tony133 force-pushed the feat/dropdowns-versions-nest branch from 9a4a4b6 to 09dcdd4 Compare May 23, 2022 14:30
Comment on lines +26 to +30
<a href="https://docs.nestjs.com/v8/" target="_blank">8.x</a>
<a href="https://docs.nestjs.com/v7/" target="_blank">7.x</a>
<a href="https://docs.nestjs.com/v6/" target="_blank">6.x</a>
<a href="https://docs.nestjs.com/v5/" target="_blank">5.x</a>
<a href="https://docs.nestjs.com/v4/" target="_blank">4.x</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://docs.nestjs.com/v8/" target="_blank">8.x</a>
<a href="https://docs.nestjs.com/v7/" target="_blank">7.x</a>
<a href="https://docs.nestjs.com/v6/" target="_blank">6.x</a>
<a href="https://docs.nestjs.com/v5/" target="_blank">5.x</a>
<a href="https://docs.nestjs.com/v4/" target="_blank">4.x</a>
<a href="https://docs.nestjs.com/v8/" target="_self">8.x</a>
<a href="https://docs.nestjs.com/v7/" target="_self">7.x</a>
<a href="https://docs.nestjs.com/v6/" target="_self">6.x</a>
<a href="https://docs.nestjs.com/v5/" target="_self">5.x</a>
<a href="https://docs.nestjs.com/v4/" target="_self">4.x</a>

wouldn't this behavior be better? I mean, if one want to see the docs of another version, they problably don't care about the current one

@dijonkitchen
Copy link

This would be good for reviewing documentation on migrating older versions.

@Tony133 Tony133 force-pushed the feat/dropdowns-versions-nest branch from d4c188c to 3013d01 Compare July 8, 2022 19:37
@Tony133 Tony133 force-pushed the feat/dropdowns-versions-nest branch from 3be5efa to afedda4 Compare July 8, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants