Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update images and fix outdated info in rfcs-0004 #412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: update images and fix outdated info in rfcs-0004 #412

wants to merge 1 commit into from

Conversation

peterzhb
Copy link

@peterzhb peterzhb commented Mar 30, 2023 •
edited
Loading

This PR refactors several outdated info in rfcs-0004. It also unifies the terms used across the doc. Furthermore, the images are updated in correspondence with the content to be more readable.

@peterzhb peterzhb requested review from a team and doitian as code owners March 30, 2023 14:39
@peterzhb peterzhb force-pushed the @peter/fix-minor-0004 branch 2 times, most recently from 8d00f75 to 945818f Compare March 31, 2023 02:56
@peterzhb peterzhb force-pushed the @peter/fix-minor-0004 branch from 945818f to c1cc6ce Compare April 3, 2023 09:20
@peterzhb peterzhb force-pushed the @peter/fix-minor-0004 branch from c1cc6ce to 1799a44 Compare April 12, 2023 01:20
doitian
doitian reviewed Apr 13, 2023
View reviewed changes
rfcs/0004-ckb-block-sync/0004-ckb-block-sync.zh.md

之后会使用以下图示表示不同状态的块：
块的状态会沿着依赖传递。按照上面的编号，子块的状态编号一定不会大于父块的状态编号。首先，如果某个块是无效的，那依赖它的子孙块自然也是无效的。另外，同步的每一步代价都远远高于前一步，且每一步都可能失败。如果子节点先于父节点进入下一阶段，而父节点被验证为无效，那子节点上的工作量就浪费了。而且，子块验证是要依赖父块的信息的。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

状态列表被改成无序列表，所以现在没有状态编号了。

@doitian doitian added the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec left review comments

@doitian doitian doitian left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterzhb @doitian @eval-exec