Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LZ4 rocksdb compression type #4694

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 24, 2024

What problem does this PR solve?

Issue Number: close #4682

Problem Summary:

This PR introduces support for configuring compression=kLZ4Compression under the [CFOptions "default"] section in the ckb default.db-options file, enabling RocksDB to use LZ4 compression.

Related changes

  • let ckb-rocksdb support LZ4

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/support-more-rocksdb-compression-type branch from 21e0802 to b91abfa Compare October 24, 2024 07:07
@eval-exec eval-exec changed the title Support more rocksdb compression type Support LZ4 rocksdb compression type Oct 24, 2024
@eval-exec eval-exec marked this pull request as ready for review October 24, 2024 08:21
@eval-exec eval-exec requested a review from a team as a code owner October 24, 2024 08:21
@eval-exec eval-exec requested review from quake and removed request for a team October 24, 2024 08:21
@eval-exec eval-exec force-pushed the exec/support-more-rocksdb-compression-type branch from b91abfa to 801e240 Compare October 24, 2024 08:22
@zhangsoledad zhangsoledad added this pull request to the merge queue Oct 24, 2024
Merged via the queue into nervosnetwork:develop with commit c49fdbf Oct 24, 2024
32 checks passed
@doitian doitian mentioned this pull request Nov 18, 2024
2 tasks
@eval-exec eval-exec deleted the exec/support-more-rocksdb-compression-type branch November 19, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link ckb-rocksdb with ZSTD, LZ4,etc.
2 participants