Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename both new methods to
backupWorkingPatchList
and `restorePatch…
…List` (#6) * [org.SfietKonstantin.patchmanager.xml] Rename both new methods … to `backupWorkingPatchList` and `restorePatchList` Reference: sailfishos-patches#437 (comment) * [patchmanagerobject.cpp] First round of name changes * [patchmanagerobject.h] Carry out all name changes * [patchmanager.cpp] Carry out all name changes * [patchmanager.h] Carry out all name changes * [org.SfietKonstantin.patchmanager.xml] Fix accidentally swapped names * [PatchManagerPage.qml] Carry out all name changes * [patchmanager-tool] Carry out all name changes * [main.cpp] Carry out all name changes ¿Is the masking of the **"** with **\** correct in C++? * [PatchManagerPage.qml] Enhance wording of menu entry Better, but still not really good, IMO. Issue is, it must be terse enough to fit in a single line in portrait orientation on a Jolla 1 (i.e., 540 pixels width)! * [index.qdoc] Overhaul Sorry, I became carried away: Originally I only adjusted the original lines 307 & 310, then started fixing a few typos, enhanced a few phrases etc. etc. and ended up in going over the whole file. Open points: - Line 110: "\uicontrol" Is this correct markup? Does the sentence make sense this way? - Line 161: "\badcode" Is this correct markup? - Line 225: "In this state, all enabled services are disabled, and PM must be reactivated via the GUI." "Patches" instead of "services"? - Line 289: "\warning" Not "Warning"? I.e., is it a markup term? * [patchmanagerobject.cpp] Complete name changes Questions: - Was capitalising "\c Patches" in line 372 O.K.? - Is the "\sa" in line 373 correct? * [patchmanagerobject.cpp] Try to rectify comments lines 344 - 387 Please review thoroughly! It became obvious, that some copy&paste flaws existed, but I am not sure, if I rectified them correctly. I simply assumed that the code is correct, but maybe (unlikely) the documentation mismatch was the other way around. * [patchmanagerobject.cpp] Complete name changes & overhaul Notes / questions: - Line 587: "()"? Function name missing? - Line 1103: "on the bus" -> "on D-Bus"? - Line 1198: Ambiguous, especially the second "all". - Line 1705: Not better "/sa" instead of "See also"? - Line 2121: Is that an accidentally deleted comment: Check `git blame` * [patchmanagerobject.cpp] Revert over-eagerly applied capitalisation * [index.qdoc] Two minor rectifications of yesterday's work * [index.qdoc] Fix ambiguosity and missing "that" in line 120 * [index.qdoc] Enhance lines 124 and 135 a little bit * [index.qdoc] More minor fixes * [index.qdoc] Even moere small fixes * [index.qdoc] More nitpicks * [index.qdoc] Rectify broken sentence, detected and forgotten multiple times
- Loading branch information