Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interface for error pages #2589

Merged
merged 12 commits into from
Dec 18, 2024
Merged

feat: add interface for error pages #2589

merged 12 commits into from
Dec 18, 2024

Conversation

saimonkat
Copy link
Collaborator

@saimonkat saimonkat commented Dec 3, 2024

This PR brings interface for broken pages

This is the continue for #2559, updated with fixes for header sidebar issue, which causes it's revert #2582

Details:

  • All pages have a classic full header
  • GitHub stars are hidden from the Error pages due to the client rendering
Before:

image

After:
image

TO-DO:
there is an issue for the Draft Blog Post (made for the purpose of testing this PR),
should be fixed after release (remove empty author)

Preview

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neon-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 0:10am

@saimonkat
Copy link
Collaborator Author

@ruf-io we've updated this PR with fixes for missing header sidebar and tested all carefully
now all pages have classic header sidebar, except Error, where GitHub stars are hidden from due to the client rendering

please take a look once again and approve if we good to merge 🙏

@saimonkat saimonkat marked this pull request as ready for review December 3, 2024 14:07
@saimonkat saimonkat mentioned this pull request Dec 11, 2024
@saimonkat saimonkat force-pushed the broken-pages-support branch from a6526e5 to 658daa0 Compare December 17, 2024 12:08
@saimonkat saimonkat merged commit 79e176f into main Dec 18, 2024
6 checks passed
@saimonkat saimonkat deleted the broken-pages-support branch December 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants