Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirement.txt 2 #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

entzyeung
Copy link

tqdm == 4.64.1 ## previously 4.46.0 ## 26Jan2023 changed to >= 4.64.1

en-core-web-sm @ https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.0/ # 26Jan2023 commented out

To be able to merge a pull request, there are a few checks:

DO NOT DELETE THE BELOW TEXT FROM THE BODY OF THE PULL REQUEST. ADD YOUR DESCRIPTION(S) FROM THE POINT IT SAYS "Goal or purpose of the PR". USE THIS TEMPLATE AS IS.


USE THE CHECKLIST TO SHOW PROGRESS AND A REMINDER FOR YOURSELF.

Checklist

Please check the options that you have completed and strike-out the options that do not apply via this pull request:

  • a clear title and description to the Pull Request has been provided
  • you have read
  • the pull request passes the tests (./test-coverage.sh "tests slow-tests") - this will also be visible via the Code coverage report and CI/CD task on the Pull Request
  • you have performed some kind of smoke test by running your changes in an isolated environment i.e. Docker container, Google Colab, Kaggle, etc...
  • the notebooks are updated (see notebooks folder, read the Notebooks docs)
  • CHANGELOG.md has been updated (please follow the existing format)

Goal or purpose of the PR

Changes implemented in the PR

tqdm == 4.64.1 ## previously 4.46.0 ## 26Jan2023 changed to >= 4.64.1

# en-core-web-sm @ https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.0/ # 26Jan2023 commented out
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request focuses on updating dependencies within the requirements.txt file to ensure compatibility and leverage new features or bug fixes from the updated packages. Specifically, it updates the version of tqdm and comments out the en-core-web-sm model from spaCy, indicating a shift in dependency requirements or usage patterns.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the updated version of tqdm does not introduce any breaking changes or incompatibilities with the current codebase. It's crucial to verify that all functionalities relying on tqdm still operate as expected after the update.
  • Clarify the reason for commenting out the en-core-web-sm model. If this model is no longer required, consider removing it entirely from the requirements.txt to avoid confusion. If it's temporarily disabled, provide context in the PR description or comments within the requirements.txt file.
  • The PR description template includes several unchecked items under the checklist section. It's important to complete these items or provide a rationale for any that are not applicable. This ensures that the PR is thoroughly vetted and meets the project's contribution guidelines.
  • The 'Goal or purpose of the PR' section is left empty. Providing a brief description of the motivation behind the updates can help reviewers understand the context and rationale for the changes. This is especially important for dependency updates, as they can have wide-ranging impacts on the project.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant