Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with non-ASCII characters in paths when the system property file.encoding was overriden #80

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jul 4, 2024

Charset.defaultCharset() sadly cannot be used to write files that are always read using the Platforms native encoding, since a user can override it. Use the new native.encoding property instead, which cannot be overridden and contains the actual system encoding used for program arguments, etc.

Also update DevLaunch to always use UTF-8 to make it 1) reliable and 2) bring it in line with FML JUnit which parses the same argument file using UTF-8 already.

… always read using the Platforms native encoding, since a user can override it.
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 4, 2024

  • Publish PR to GitHub Packages

Last commit published: d6cc8b0c1ef73a7f10c2e92614fc043f3bbcc2d7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #80' // https://github.com/neoforged/ModDevGradle/pull/80
        url 'https://prmaven.neoforged.net/ModDevGradle/pr80'
        content {
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
        }
    }
}

@shartte shartte requested a review from Technici4n July 4, 2024 01:42
@shartte shartte merged commit 185d8da into main Jul 5, 2024
5 checks passed
@shartte shartte deleted the real-charset-fix branch July 5, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants