Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eagerly create the configs needed by the NFRT manifest to avoid a ConcurrentModificationException #74

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jun 29, 2024

This moves creation of the NFRT manifest configs to be outside of lazy task configuration.

I have to do this to fix a ConcurrentModificationException that occurs when another subproject tries to resolve exposed Minecraft artifacts, since this triggers lazy task configuration during resolution of a configuration.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 29, 2024

  • Publish PR to GitHub Packages

Last commit published: 53b2f675e7613e3b601974f02dc58458ccdcf3b5.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #74' // https://github.com/neoforged/ModDevGradle/pull/74
        url 'https://prmaven.neoforged.net/ModDevGradle/pr74'
        content {
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
        }
    }
}

@Technici4n Technici4n merged commit 9eec30e into main Jun 30, 2024
5 checks passed
@Technici4n Technici4n deleted the fix-lazy-configs branch June 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants