Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jar-in-Jar: Fix specified version range being ignored #32

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jun 16, 2024

The range in the JiJ metadata was currently always based on the actual artifact version.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 16, 2024

  • Publish PR to GitHub Packages

Last commit published: e6b4de403f200ca4b6609df7c712e27222743d3d.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #32' // https://github.com/neoforged/ModDevGradle/pull/32
        url 'https://prmaven.neoforged.net/ModDevGradle/pr32'
        content {
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
        }
    }
}

Copy link
Member

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could really do with some tests.. :P

@Technici4n Technici4n merged commit 1fb37a7 into main Jun 16, 2024
5 checks passed
@Technici4n Technici4n deleted the fix-ranges-being-ignored branch June 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants