Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jar-in-Jar: Prefix Jar files embedded from subprojects to avoid JPMS module-name conflicts #31

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jun 16, 2024

I.e. for a subproject named coremod in a project with group testmod, the resulting jar filename would be testproject.coremod.
This would result in module name testproject.coremod when no Automatic-Module-Name is specified.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 16, 2024

  • Publish PR to GitHub Packages

Last commit published: 83151d077541f2032fd17b3a95e7a840a8ea2cd9.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #31' // https://github.com/neoforged/ModDevGradle/pull/31
        url 'https://prmaven.neoforged.net/ModDevGradle/pr31'
        content {
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
        }
    }
}

@Technici4n Technici4n merged commit 5acdebf into main Jun 16, 2024
5 checks passed
@Technici4n Technici4n deleted the jij-project-dep-disambiguation branch June 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants