Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jar-in-Jar: Throw when only incompatible version ranges were specified #30

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Jun 16, 2024

For example, Gradle allows [1.0,2.0[, but Maven insists on [1.0,2.0).

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 16, 2024

  • Publish PR to GitHub Packages

Last commit published: 7a93e007d9298c5bc7bdc22c611ff10f28121d02.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #30' // https://github.com/neoforged/ModDevGradle/pull/30
        url 'https://prmaven.neoforged.net/ModDevGradle/pr30'
        content {
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
        }
    }
}

Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we throw if any version range is invalid?

@shartte
Copy link
Collaborator Author

shartte commented Jun 16, 2024

Shouldn't we throw if any version range is invalid?

IDK, it would certainly make the coder easier...

@shartte shartte requested a review from Technici4n June 20, 2024 19:00
@shartte shartte merged commit b66eb53 into main Jun 20, 2024
4 checks passed
@shartte shartte deleted the validate-version-ranges branch June 20, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants