Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createLaunchScript tasks compiling dependent projects in some cases #145

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Aug 26, 2024

I ran into that while testing NeoDev... When this happens, a compilation failure will cause the entire IDE sync to fail.

So this PR removes the dependency capture by using a project.provider(() -> xxx.get()) indirection. Additionally, we need to stop using @InputFiles entirely, and instead pass the classpath using a ListProperty<String>.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 26, 2024

  • Publish PR to GitHub Packages

Last commit published: 2014d22addcff3bfa3934c581641b119e0cf28b6.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #145' // https://github.com/neoforged/ModDevGradle/pull/145
        url 'https://prmaven.neoforged.net/ModDevGradle/pr145'
        content {
            includeModule('net.neoforged', 'moddev-gradle')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
        }
    }
}

@shartte shartte merged commit 2e79345 into main Aug 31, 2024
4 checks passed
@shartte shartte deleted the fix-launchscript-compile branch August 31, 2024 09:21
@neoforged-releases
Copy link

🚀 This PR has been released as ModDevGradle version 2.0.20-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants