Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeConnector #1

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

SafeConnector #1

wants to merge 1 commit into from

Conversation

0xAryanShah
Copy link
Collaborator

Implemented Safe Connector

@0xAryanShah 0xAryanShah requested a review from 0xtemujin March 19, 2023 17:17
@dsudit01
Copy link

  • Instead of checking each time if the user is connected with the "safe connector", we can probably just do this check once in the CanNav, and save to the NetworkInfo Zustand Store to maintain the state. (will stop some repetative code)

@dsudit01
Copy link

  • the site at the moment has loading states for the transactions by a single user. The safe introduces a new state "CollectingSignaturePool" which we do not account for in the loading modals. We will have to update the messages to include this state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants