Index handling methods #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
index-handling-methods
branch
from
6fb1a4b to
20fb738
Compare
willtai
force-pushed
the
index-handling-methods
branch
from
20fb738 to
77817b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored create vector index and drop index into their own methods. Created method for creating fulltext index.
Note that the
GenAIClientwill be removed after this work.Implementation
create_vector_index(),drop_index(), andcreate_fulltext_index()IndexModeltype that validates the Neo4j python driver. TheDriverclass is not a type that Pydantic can read.FulltextIndexModeltypeSee the llama-index
create_new_keyword_index()implementation for reference.