Add custom retrieval query option in similarity search #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
from
4eaba67 to
2066c72
Compare
willtai
force-pushed
the
jonbesga/tests
branch
3 times, most recently
from
a262c48 to
d1685dc
Compare
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
from
7048d56 to
4a5e749
Compare
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
5 times, most recently
from
f0dc1d6 to
86a98b1
Compare
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
from
5066a2a to
c34b6ff
Compare
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
from
c34b6ff to
27ecffb
Compare
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
from
27ecffb to
259c2d6
Compare
…ent's _database_query() Changed test_client.py to have mocks at execute_query level Changed precommit config to include ruff linting and formatting Update pre-commit Corrected cypher query error test and dimensions constraint in CreateIndexModel data type ruff formatting
willtai
force-pushed
the
willtai/add-custom-retrieval-query
branch
from
89bdf87 to
779960f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to append a custom query to the original retrieval query. This is in its own method. This is as seen in langchain and llama-index:
Also the returned type of
custom_similarity_search()isAny, as the returned type can be unstructured depending on the custom query.Also allows custom parameters to be added for the query
Tests
CypherSyntaxError