Add debug logging in retrievers #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones.
stellasia
reviewed
May 7, 2024
stellasia
reviewed
May 7, 2024
|
Currently the codebase is still small so this looks good. I think in time we can centralize logging more as the codebase grows larger Non-blocking comment: I would prefer we use f-strings wherever possible for readability. |
willtai
pushed a commit
that referenced
this pull request
May 7, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 9, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 9, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 13, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 13, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 13, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 13, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 14, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 20, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 20, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
willtai
pushed a commit
that referenced
this pull request
May 20, 2024
* Add debug logging in retrievers We do not set any basic config on the loggers, but leave that for aplication developers to keep the log format consistent with their existing ones. * Drop value serialization and leave that to the logger * Add string placeholder in logger message * Improve log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not set any basic config on the loggers, but leave that for application developers to keep the log format consistent with their existing ones.
This can be tested by logging
DEBUGwhen running tests: