Setup E2E Test pipeline and add E2E tests for vector and hybrid retrievers #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
willtai/e2e-tests
branch
2 times, most recently
from
9c004e8 to
440064c
Compare
willtai
force-pushed
the
willtai/e2e-tests
branch
5 times, most recently
from
3062778 to
bbd1c82
Compare
willtai
changed the title
willtai
commented
May 1, 2024
stellasia
reviewed
May 2, 2024
oskarhane
reviewed
May 2, 2024
oskarhane
reviewed
May 2, 2024
Setup neo4j db for e2e tests
willtai
commented
May 2, 2024
willtai
added a commit
that referenced
this pull request
May 7, 2024
…evers (#24) * Added E2E tests, new GitHub workflow, and separated out unit tests Setup neo4j db for e2e tests * Refactor query tail generation to separate function --------- Co-authored-by: Oskar Hane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tests/unitfolderdrop_indexfunction to only drop index if it exists. (Let me know if you think this is appropriate, or should we have a different function for this?)Notable implementation details
drop_index()function runs the query"DROP INDEX $name IF EXISTS"instead of"DROP INDEX $name". I changed this to be used for dropping the indexes in the E2E tests fixtures.get_search_query()constructs Cypher queries. Previous bugs were caught with the E2E tests 🎉Running tests
To run the E2E tests:
To run the unit tests: