Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to load PDF from HTTP + specify file system from string (useful for config files) #230

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add ability to load PDF from HTTP + specify file system from string (useful for config files) #230

wants to merge 21 commits into from

Conversation

stellasia
Copy link
Contributor

Description

Note

Please provide a description of the work completed in this PR below

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity:

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
e9712a9
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
b52c45e
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
84c1780
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
47d4782
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
bc7a2f9
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
a945284
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
4e13c23
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
5367bed
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
21d1223
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
3329cd7
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
d8f6364
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
4cec2f3
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
4445b49
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
939b18c
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
1104519
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
1893b85
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
6e4ebda
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python
8db7f01
@stellasia
Fix PdfLoader, add ability to specify file system from string
33e0f41
@stellasia
Merge branch 'main' of https://github.com/neo4j/neo4j-graphrag-python …
621f4b9 
…into fix/pdf-loader-http
@stellasia
Make PdfLoader work with config files
19c9e06
@stellasia stellasia marked this pull request as ready for review December 12, 2024 17:03
@stellasia stellasia requested a review from a team as a code owner December 12, 2024 17:03
alexthomas93
alexthomas93 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@alexthomas93 alexthomas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments

src/neo4j_graphrag/experimental/components/pdf_loader.py Show resolved Hide resolved
src/neo4j_graphrag/experimental/pipeline/config/object_config.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexthomas93 alexthomas93 alexthomas93 approved these changes

@willtai willtai Awaiting requested review from willtai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellasia @alexthomas93