Jonbesga/tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbesga
force-pushed
the
jonbesga/tests
branch
2 times, most recently
from
8c57a4f to
4b6fb94
Compare
willtai
reviewed
Mar 4, 2024
jonbesga
force-pushed
the
jonbesga/tests
branch
3 times, most recently
from
f8bb374 to
a009b40
Compare
willtai
reviewed
Mar 8, 2024
willtai
force-pushed
the
jonbesga/tests
branch
2 times, most recently
from
4222460 to
0c921fe
Compare
relock dependencies Linting with ruff fixed linting issues
willtai
force-pushed
the
jonbesga/tests
branch
3 times, most recently
from
a262c48 to
d1685dc
Compare
willtai
reviewed
Mar 13, 2024
…ent's _database_query() Changed test_client.py to have mocks at execute_query level Changed precommit config to include ruff linting and formatting Update pre-commit Corrected cypher query error test and dimensions constraint in CreateIndexModel data type ruff formatting remove drop index in example
jonbesga
force-pushed
the
jonbesga/tests
branch
from
f857e14 to
9af3802
Compare
willtai
reviewed
Mar 18, 2024
| YIELD node, score | ||
| """ | ||
|
|
||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
Is this ValueError arising because score is not a float? I think with the custom retrieval query feature we may not be so strict on the returned type from similarity_search() as the user can technically return any type they want, but technically not part of this PR so just an FYI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.