Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Getting Started instructions to README and CLA checks #17

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Adds Getting Started instructions to README and CLA checks #17

merged 3 commits into from
Apr 23, 2024

Conversation

willtai
Copy link
Contributor

@willtai willtai commented Apr 22, 2024

Summary

  • Adds CLA check
  • Adds instructions for contribution on README

stellasia
stellasia reviewed Apr 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
stellasia
stellasia reviewed Apr 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@willtai willtai changed the title Adds Getting Started instructions to README Adds Getting Started instructions to README and CLA checks Apr 23, 2024
@willtai willtai force-pushed the willtai/add-cla-check branch 3 times, most recently from 9131908 to 978a8a3 Compare April 23, 2024 10:46
@willtai willtai marked this pull request as ready for review April 23, 2024 11:01
willtai and others added 2 commits April 23, 2024 14:04
@willtai
Adds Getting Started instructions to README
013ebab
@willtai
Retriever base type (#16)
216bcc3 
* Refactored Retriever object

* Added comment about Embedder type in docstring
@willtai willtai force-pushed the willtai/add-cla-check branch from ad1b76a to 9e54b99 Compare April 23, 2024 13:04
@willtai willtai force-pushed the willtai/add-cla-check branch from ff080a1 to ced9b78 Compare April 23, 2024 14:02
@willtai willtai requested a review from a team April 23, 2024 14:59
oskarhane
oskarhane approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this

@willtai willtai merged commit f0173d6 into main Apr 23, 2024
6 checks passed
@willtai willtai deleted the willtai/add-cla-check branch April 23, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellasia stellasia stellasia left review comments

@oskarhane oskarhane oskarhane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willtai @oskarhane @stellasia