Retriever base type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
willtai/retriever-base-type-and-embedder-error-handling
branch
2 times, most recently
from
7b5ac29 to
792bfb6
Compare
willtai
force-pushed
the
willtai/retriever-base-type-and-embedder-error-handling
branch
from
792bfb6 to
e6b43dd
Compare
willtai
deleted the
willtai/retriever-base-type-and-embedder-error-handling
branch
willtai
added a commit
that referenced
this pull request
Apr 23, 2024
* Refactored Retriever object * Added comment about Embedder type in docstring
willtai
added a commit
that referenced
this pull request
Apr 23, 2024
* Refactored Retriever object * Added comment about Embedder type in docstring
willtai
added a commit
that referenced
this pull request
Apr 23, 2024
* Refactored Retriever object * Added comment about Embedder type in docstring
willtai
added a commit
that referenced
this pull request
Apr 23, 2024
* Refactored Retriever object * Added comment about Embedder type in docstring
willtai
added a commit
that referenced
this pull request
Apr 23, 2024
* Adds Getting Started instructions to README * Retriever base type (#16) * Refactored Retriever object * Added comment about Embedder type in docstring * Adds Getting Started instructions and CLA Check workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Retrieverbase type. This makes more sense semantically and the other retriever methods can inherit from this class.