Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds HybridRetriever #14

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Adds HybridRetriever #14

merged 2 commits into from
Apr 26, 2024

Conversation

willtai
Copy link
Contributor

@willtai willtai commented Apr 19, 2024 •
edited
Loading

Summary

We want to add a retriever strategy for Hybrid Search.

  • Adds HybridRetriever
  • Adds example for hybrid search
  • Add tests for HybridRetriever

@willtai willtai force-pushed the willtai/hybrid-retriever branch 3 times, most recently from 39bd5fa to 85bcfac Compare April 24, 2024 16:34
@willtai willtai marked this pull request as ready for review April 24, 2024 16:34
@willtai willtai requested a review from a team April 24, 2024 16:34
@willtai willtai force-pushed the willtai/hybrid-retriever branch from 85bcfac to b21d513 Compare April 24, 2024 16:35
@willtai willtai changed the title Adds HybridSearchRetriever and creates abstract base class Retriever Adds HybridSearchRetriever Apr 25, 2024
oskarhane
oskarhane reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but there should not be different questions for the two indexes.

examples/hybrid_search.py Outdated Show resolved Hide resolved
src/neo4j_genai/retrievers.py Outdated Show resolved Hide resolved
@willtai willtai force-pushed the willtai/hybrid-retriever branch 3 times, most recently from b104f65 to 5182bb9 Compare April 25, 2024 16:21
willtai
willtai commented Apr 25, 2024
View reviewed changes
src/neo4j_genai/types.py Outdated Show resolved Hide resolved
@willtai willtai requested a review from a team April 25, 2024 16:23
@willtai willtai force-pushed the willtai/hybrid-retriever branch from 5182bb9 to a35915a Compare April 25, 2024 16:24
oskarhane
oskarhane reviewed Apr 26, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@willtai willtai force-pushed the willtai/hybrid-retriever branch from a35915a to 267fb72 Compare April 26, 2024 09:03
@willtai willtai force-pushed the willtai/hybrid-retriever branch from 126aa48 to 49a7f8d Compare April 26, 2024 10:53
@willtai willtai requested a review from oskarhane April 26, 2024 10:54
@willtai willtai changed the title Adds HybridSearchRetriever Adds HybridRetriever Apr 26, 2024
oskarhane
oskarhane approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looking forward to the next PR with HybridCypherRetriever :)

@willtai willtai merged commit eaf27ab into main Apr 26, 2024
7 checks passed
@willtai willtai deleted the willtai/hybrid-retriever branch April 26, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarhane oskarhane oskarhane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willtai @oskarhane