Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inline math delimiters (markdown cell) #9

Merged
merged 3 commits into from
Mar 30, 2023
Merged

fix inline math delimiters (markdown cell) #9

merged 3 commits into from
Mar 30, 2023

Conversation

prudhomm
Copy link
Contributor

@prudhomm prudhomm commented Mar 26, 2023 •
edited
Loading

prudhomm added 2 commits March 26, 2023 22:19
@prudhomm
fixes neo4j-documentation#8
d2f5559
@prudhomm
fixes neo4j-documentation#10
2665d4a 
add an extra `\n` to ensure enough room around list
@prudhomm prudhomm changed the title fixes #8: inline math non properly displayed in vscode-jupyter markdown cells conversion fixes Mar 26, 2023
@ggrossetie
Copy link
Contributor

Test is failing because of the extra newline.

  1) Jupyter converter
       should convert an exercise guide with an admonition block to ipynb:

      AssertionError: expected 'An admonition block may contain compl…' to equal 'An admonition block may contain compl…'
      + expected - actual

       - one
       - two
       - three
       
      -
       Another paragraph.

@ggrossetie
Copy link
Contributor

Could you please move your second commit to a dedicated branch and pull request? That way, I can merge your first commit which resolves #8

Anyway, nice work 👍🏻

@prudhomm
Copy link
Contributor Author

this is done @ggrossetie

@ggrossetie ggrossetie changed the title markdown cells conversion fixes fix inline math delimiters (markdown cell) Mar 30, 2023
@ggrossetie ggrossetie merged commit 38044e3 into neo4j-documentation:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inline math is not displayed properly in vscode-jupyter
2 participants
@prudhomm @ggrossetie