Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use xfail instead of silently passing tests #291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use xfail instead of silently passing tests #291

wants to merge 1 commit into from
+301 −231

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Nov 6, 2021 •
edited
Loading

Motivation and context:
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.

Interactions with other PRs:
none

How has this been tested?
existing tests

How long should this take to review?

  • Average (neither quick nor lengthy)

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 1.3.0 milestone Nov 6, 2021
@jgosmann jgosmann marked this pull request as ready for review November 6, 2021 19:19
@jgosmann jgosmann requested review from bjkomer and arvoelke November 6, 2021 19:19
@jgosmann jgosmann force-pushed the xfail branch 4 times, most recently from c5f250a to 817dc5b Compare November 13, 2021 19:30
@jgosmann
Use xfail instead of silently passing tests
0a3d99a 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
@jgosmann
Copy link
Collaborator Author

@bjkomer, @arvoelke Does anyone have time to review this soon? Then it could be included in 1.3 release. (No worries if not, then it will be released later. It is barely a user-facing change anyways.)

@jgosmann jgosmann removed this from the 1.3.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjkomer bjkomer Awaiting requested review from bjkomer

@arvoelke arvoelke Awaiting requested review from arvoelke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use xfail instead of NotImplementedError to skip tests unsupported by an algebra
1 participant
@jgosmann