Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging instead of print #860

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Logging instead of print #860

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
092545e
Remove unused function with obscure print statement
astoeckel Feb 7, 2017
953d1ce
Replace calls to "print" with corresponding logging calls
astoeckel Feb 7, 2017
138da74
Set default log level to info, change the logging format string
astoeckel Feb 7, 2017
04fbdbb
Change server request log level to debug
astoeckel Feb 7, 2017
34ce206
Sort imports
astoeckel Feb 7, 2017
c611197
Remove no longer needed compatibility imports for print
astoeckel Feb 7, 2017
cea7db2
squash! Replace calls to "print" with corresponding logging calls
jgosmann Feb 8, 2017
63e3d4e
squash! Replace calls to "print" with corresponding logging calls
jgosmann Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nengo_gui/guibackend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def get_session(self):
return session

def log_message(self, format, *args):
logger.info(format, *args)
logger.debug(format, *args)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are “these” log messages? It seems that this function isn't called in normal operation. Maybe in some specific error cases? But if it is error cases a higher log level might be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is called from the web server base class and is called once for each incoming request.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, for some reason those messages did not appear on my Macbook (potentially I was running the wrong version of Nengo GUI). I agree that the debug log level makes more sense.



class ModelContext(object):
Expand Down