Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOJO-179 | throw a LogicException instead of silently not updating the state #103

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

KOJO-179 | throw a LogicException instead of silently not updating the state #103

wants to merge 11 commits into from

Conversation

alexberryman
Copy link
Contributor

Changes

  • Throw a LogicException instead of silently not updating the state

alexberryman and others added 10 commits October 28, 2019 13:29
@alexberryman
feature/KOJO-157 | remove deprecated logging structure
c16c500
@alexberryman
feature/KOJO-157 | remove old opcahe include form docker image
1f3cd86
@mucha55
KOJO-96 | Panic job instead of crashing on userspace exceptions
2818ccf
@alexberryman
Merge pull request #90 from neighborhoods/feature/KOJO-157
87fe80c 
Feature/KOJO-157 | remove deprecated logging structure
@mucha55
Merge pull request #91 from neighborhoods/KOJO-96-no-more-exception-c…
595adf3 
…rash-looping

KOJO-96 | Panic job instead of crashing on userspace exceptions
@mucha55
KOJO-96 | Removing unnecessary interface method
f8e53a5
@mucha55
Merge pull request #93 from neighborhoods/KOJO-96-no-more-exception-c…
23b5caf 
…rash-looping

KOJO-96 | Removing unnecessary interface method
@mucha55
Merge pull request #95 from neighborhoods/KOJO-154-include-metadata-i…
0c7fdab 
…n-job-state-change-model

KOJO-154 | Include metadata in job state change model
@mucha55
Merge pull request #97 from neighborhoods/KOJO-167-169-175-update-out…
c7b3ae6 
…dated-symfony-component-dependencies

KOJO-167,169,175 | Update outdated Symfony Component dependencies
@alexberryman
throw a LogicException instead of silently not updating the state
7ca1119
mucha55
mucha55 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@mucha55 mucha55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on adding a UseCase for this? I don't mind either way

@alexberryman alexberryman changed the base branch from 5.x to master February 6, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucha55 mucha55 mucha55 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexberryman @mucha55