BREAKING CHANGE : Removed re-expose LRUCache typings #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
approved these changes
Dec 12, 2024
msgadi
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #309
By implementing this change, we ensure better compatibility between LRUCache and TypeScript, while also improving stability and reusability by providing the
Cache<K, V>interface for consistent cache management. This refactor resolves the errors related to using get-jwks being imported in other packages or project written in typescript and it avoids re-exposing the LRUCache typings, which is recommended for long-term compatibility.BREAKING CHANGE: removed re-exposing of LRUCache typings