Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed pre publish step #385

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

williamlines
Copy link
Contributor

@williamlines williamlines commented Sep 27, 2023

Removed the pre-publish step to run tests, since the time delay caused by running these tests can cause the release to fail due to the optic token expiring. The repo needs to pass CI anyway for the release to be successful, so this step was unnecessary.
closes #368

Copy link
Member

@relvao relvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamlines williamlines merged commit 05b02d7 into master Sep 27, 2023
6 of 7 checks passed
@williamlines williamlines deleted the fix/inconsitent-optic-releases branch September 27, 2023 14:47
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent releases to npm
2 participants