-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context.js updates w/ graphQL #129
base: main
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @ndimatteo on Vercel. @ndimatteo first needs to authorize it. |
Hey there @jpvalery, I appreciate the work you put into this! I checked your branch preview, but I'm not seeing any console errors (aside from some vercel.live api calls). It's a bit hard for me to decipher what's going on in your PR, both in terms of switching things to cart creation with graphQL as opposed to checkout creation with the buy sdk, as well as the formatting for the file being incorrect (looks like you didn't have prettier set up to match the project settings?). I truly do not have the capacity to dig into this further right now, and like I mentioned before– I have plans to switch to I hope you can understand, and if you are able to debug this on your own (and get the formatting fixed up), I'm happy to test and merge! |
@ndimatteo you're welcome! Totally understand the lack of bandwidth 👍 Apologies for the prettier mixup. I've updated that branch to use your config. I'll keep hacking at this in the hope I can fix it. Worst case scenario, the queries above might help your migration. |
(Tentative for #125)
@ndimatteo this is how far I managed to get but I'm scratching my head with
SiteContextProvider
:(In this current state, the project builds and deploys. But products are stuck on "loading" (see my branch preview).
I think that there's a tiny bit missing in SiteContextProvider to get this to work. I have tested all the queries and they're working.
Any insights or guidance you could provide to help me finish shipping this would be greatly appreciated 🙏