Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconnect #113

Merged
merged 1 commit into from
Dec 2, 2023
Merged

reconnect #113

merged 1 commit into from
Dec 2, 2023

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Dec 2, 2023 •
edited
Loading

Current implementation does not reconnect relays when the relay is restarted.

DO NOT MERGE

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 2, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@mattn
Copy link
Contributor Author

mattn commented Dec 2, 2023

@fiatjaf Can you take a look? This change make SubMany forever until context become done.

@mattn mattn changed the title [WIP] reconnect reconnect Dec 2, 2023
@fiatjaf
Copy link
Collaborator

fiatjaf commented Dec 2, 2023

Looks great, thanks!

I think it would be better with one of those exponential backoff things instead of always 3 seconds, but I'll I try to add that myself.

@fiatjaf fiatjaf merged commit cb8b40b into nbd-wtf:master Dec 2, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattn @fiatjaf