Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with null result for federated objects #101

Merged
merged 1 commit into from
Apr 21, 2020
+10 −0
Merged

Fix bug with null result for federated objects #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions execute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,16 @@ func executorFindInsertionPoints(resultLock *sync.Mutex, targetPoints []string,
// get the type of the object in question
selectionType := foundSelection.Definition.Type

if rootValue == nil {
if selectionType.NonNull {
err := fmt.Errorf("Received null for required field: %v", foundSelection.Name)
log.Warn(err)
return nil, err
} else {
return nil, nil
}
}

// if the type is a list
if selectionType.Elem != nil {
log.Debug("Selection should be a list")
Expand Down