Fix bug with null result for federated objects #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm experiencing an issue with federation. I have a schema like the following:
When I make a request like this:
It works if all parents have a child. However, if any one
child
field is null, then the result of the query is basically empty. No data. No error.Solution
The MR detects the null root object and returns a nil insertionPoint list, so that we don't execute the next step for a null child.
It also validates that the field is nullable. If it's not, and the root object is null, then it triggers an error. In this case, the result is still empty. Unfortunately I haven't figured out how to solve that part yet, but I've at least added a warning log for it. It should be uncommon, as it means there is a bug in the queryer (it's returning null for non-nullable fields), but still it would be nice to return something like
"cannot return null for non-nullable field
to the caller.