(#122) Enable pedantic mode #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good, also have to update the docs and examples with the new fields |
Here we enable the new ability in jsm.go to use nat's pedantic mode. As a side effect certain stream and consumer fields, as well as tests for the pedantic behaviour, have been added. Streams can now use the `mirror_direct` field which allow mirror streams to specify direct get behaviour. Consumer limits can now be defined in stream definitions with the `max_ack_pending` and `inactive_threshold` fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we enable the new ability in jsm.go to use nat's pedantic mode. As a side effect certain stream and consumer fields, as well as tests for the pedantic behaviour, have been added.
Streams can now use the
mirror_directfield which allow mirror streams to specify direct get behaviour.Consumer limits can now be defined in stream definitions with the
max_ack_pendingandinactive_thresholdfields.