(#114) Fix changing max_waiting value when delivery_subject is set
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` is set Here we update the `max_waiting` consumer resource field to be computed. This allows us to set its value to 0 when `delivery_subject` is set and not have it flip to the default on every apply. `max_waiting` now also conficts with the `delivery_subject` field, since these two imply the use of push vs pull consumers and don't make sense when specified together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we update the
max_waitingconsumer resource field to be computed. This allows us to set its value to 0 whendelivery_subjectis set and not have it flip to the default on every apply.max_waitingnow also conficts with thedelivery_subjectfield, since these two imply the use of push vs pull consumers and don't make sense when specified together.