-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ClientStates
enumeration
#619
base: main
Are you sure you want to change the base?
Conversation
@caspervonb , hello, could you possibly have a look at the PR? |
I've seen it, will review properly on Monday. Sorry caught a stomach bug mid week. |
Oh, I wish you a speedy and an easy recovery, hope you'll get well as soon as possible. |
3d8d546
to
bdd3c88
Compare
@caspervonb , rebased, there are problems, e.g., https://app.travis-ci.com/github/nats-io/nats.py/jobs/627146027 and https://app.travis-ci.com/github/nats-io/nats.py/jobs/627146023 from the details. |
Hm, did this test become flaky? https://app.travis-ci.com/github/nats-io/nats.py/jobs/627155945 - I ain't wanna fix it in this PR, just pointing it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core change is probably okay with me but, there's quite a bit of noise added to it.
@wallyqs , @caspervonb , could you approve this PR if you are fine with changes? And which contributors can I ping here as well? |
@wallyqs , @caspervonb , sorry, but pinging. |
We will take a look at this shortly. |
72112c3
to
15d63d3
Compare
15d63d3
to
59e1c6e
Compare
@Jarema , can this PR be reviewed? It requires no rebase for now and some requests were addressed. |
Resolving the relevant FIXME in the nats/aio/client.py module.
The client states are made public (out of the Client class), but not in a separate module (so be it for now). Also the code was formatted with the ruff tool.
Finally the
pytest.ini
section is appended into the pyproject.toml file.