Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ClientStates enumeration #619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stankudrow
Copy link

@stankudrow stankudrow commented Oct 5, 2024

Resolving the relevant FIXME in the nats/aio/client.py module.

The client states are made public (out of the Client class), but not in a separate module (so be it for now). Also the code was formatted with the ruff tool.

Finally the pytest.ini section is appended into the pyproject.toml file.

@stankudrow
Copy link
Author

@caspervonb , hello, could you possibly have a look at the PR?

@caspervonb
Copy link
Contributor

I've seen it, will review properly on Monday. Sorry caught a stomach bug mid week.

@stankudrow
Copy link
Author

stankudrow commented Oct 12, 2024

Oh, I wish you a speedy and an easy recovery, hope you'll get well as soon as possible.

@stankudrow stankudrow force-pushed the introduce-client-state-enum branch 2 times, most recently from 3d8d546 to bdd3c88 Compare October 15, 2024 20:28
@stankudrow
Copy link
Author

@stankudrow
Copy link
Author

Hm, did this test become flaky? https://app.travis-ci.com/github/nats-io/nats.py/jobs/627155945 - I ain't wanna fix it in this PR, just pointing it out.

Copy link
Contributor

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core change is probably okay with me but, there's quite a bit of noise added to it.

tests/test_client.py Outdated Show resolved Hide resolved
nats/aio/client.py Outdated Show resolved Hide resolved
@stankudrow
Copy link
Author

@caspervonb , @wallyqs

@stankudrow
Copy link
Author

@wallyqs , @caspervonb , could you approve this PR if you are fine with changes?

And which contributors can I ping here as well?

@stankudrow
Copy link
Author

@caspervonb , @wallyqs

@stankudrow
Copy link
Author

@wallyqs , @caspervonb , sorry, but pinging.

@Jarema
Copy link
Member

Jarema commented Nov 4, 2024

We will take a look at this shortly.

@stankudrow
Copy link
Author

@Jarema , can this PR be reviewed? It requires no rebase for now and some requests were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants