Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for iiif manifest urls not http #666

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

anthonyhashemi
Copy link
Contributor

  • Use https for iiif manifest urls not http
  • Use consistent context referebce if presentation api 3

colinbowen
colinbowen previously approved these changes Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (6693292) to head (2f57a20).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   95.88%   94.29%   -1.60%     
==========================================
  Files          16       20       +4     
  Lines        1021     1156     +135     
==========================================
+ Hits          979     1090     +111     
- Misses         42       66      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonyhashemi
Copy link
Contributor Author

Codecov diff went down, not sure why but definitely no issue with this PR's test coverage.

Copy link
Collaborator

@ltrasca ltrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anthonyhashemi anthonyhashemi merged commit 95388e0 into main Nov 27, 2024
8 of 9 checks passed
@anthonyhashemi anthonyhashemi deleted the https-for-iiif-manifest-not-http branch November 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants