New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move playwright tests to dedicated e2e tests folder #14

Merged

anthonyhashemi merged 7 commits into main from move-playwright-tests-to-dedicated-e2e-tests-folder

Oct 26, 2023

Contributor

anthonyhashemi commented Oct 25, 2023 •

edited

Loading

Changes in this PR

Organised the playwright tests and non e2e tests to be in separate locations so we can separate them when we run pytest. We can now have a run for non e2e tests (not requiring external apis just using the test flask dev server) and one for e2e tests against a real server.

anthonyhashemi force-pushed the move-playwright-tests-to-dedicated-e2e-tests-folder branch 2 times, most recently from a14a796 to 2bc8d1f Compare

October 25, 2023 18:19

anthonyhashemi commented

View reviewed changes

app/main/routes.py Show resolved Hide resolved

anthonyhashemi commented

View reviewed changes

app/main/routes.py Show resolved Hide resolved

anthonyhashemi commented

View reviewed changes

app/tests/test_search.py Show resolved Hide resolved

anthonyhashemi commented

View reviewed changes

config.py Show resolved Hide resolved

anthonyhashemi commented

View reviewed changes

e2e_tests/test_homepage.py Show resolved Hide resolved

anthonyhashemi commented

View reviewed changes

e2e_tests/test_homepage.py Show resolved Hide resolved

anthonyhashemi requested a review from colinbowen

October 25, 2023 18:29

anthonyhashemi added 7 commits

October 26, 2023 12:20


          Remove uneeded Keycloak ping and comment out broken code in routes file

1fff214


          Add basic flask-pytest test for poc-search-view

53c0696


          Delete empty tests files

5d6a45c


          Delete example playwright test file

3e06db8


          Move playwright tests to dedicated e2e tests folder

333fec9


          Fallback to empty string, not None for Config attrs when no env var s…

9afe904

…et for unit tests


          Add gh action workflow to run unit test on branch push and merge to main

131b662

anthonyhashemi force-pushed the move-playwright-tests-to-dedicated-e2e-tests-folder branch from 2bc8d1f to 131b662 Compare

October 26, 2023 11:21

anthonyhashemi commented

View reviewed changes

e2e_tests/test_record_metadata.py Show resolved Hide resolved

colinbowen approved these changes

View reviewed changes

anthonyhashemi merged commit e62b01a into main

7 checks passed

colinbowen pushed a commit that referenced this pull request


          Merge pull request #14 from nationalarchives/move-playwright-tests-to…

69a11fd

…-dedicated-e2e-tests-folder

Move playwright tests to dedicated e2e tests folder

zaiziclebby pushed a commit that referenced this pull request


          Merge pull request #14 from nationalarchives/move-playwright-tests-to…

9b8223d

…-dedicated-e2e-tests-folder

Move playwright tests to dedicated e2e tests folder

anthonyhashemi deleted the move-playwright-tests-to-dedicated-e2e-tests-folder branch

January 4, 2024 16:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet