initial commit of search feauture #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinbowen
reviewed
Oct 6, 2023
.flaskenv
Outdated
| @@ -6,7 +6,7 @@ FLASK_APP=govuk-frontend-flask.py | |||
| FLASK_DEBUG=True | |||
| FLASK_RUN_PORT=5000 | |||
| REDIS_URL=memory:// | |||
| SECRET_KEY= | |||
| SECRET_KEY= njndfnk342 | |||
There was a problem hiding this comment.
Could you remove this file, any env files should be kept for local development only. It might be good to add this to the gitignore.
colinbowen
reviewed
Oct 6, 2023
app/templates/main/search.html
Outdated
|
|
||
|
|
||
| <div class="govuk-radios govuk-radios--small govuk-radios--inline" data-module="govuk-radios"> | ||
| <p class="govuk-body govuk-link govuk-!-display-inline"> |
There was a problem hiding this comment.
I think we should move this p block to after the radio buttons, there seems to be some css that we might need to add to get everything lined up. Looks good so far.
There was a problem hiding this comment.
Have removed the advanced search link following call with Heather. No longer using feature.
colinbowen
added a commit
that referenced
this pull request
Oct 27, 2023
…feature initial commit of search feauture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following from GDS components:-